search

doyubkim / fluid-engine-dev

Fluid simulation engine for computer graphics applications
https://fluidenginedevelopment.org/
MIT License
1.9k stars 266 forks source link

where is Box2::closestNormal ? #291

Closed yangfengzzz closed 4 years ago

yangfengzzz commented 4 years ago

I notice in Box2::closestIntersectionLocal, It will use Box2::closestNormal which is actually Surface2:: closestNormal, why there use this func, I think closestIntersectionLocal is done in local space not in the world space?

doyubkim commented 4 years ago

Hi @yangfengzzz! Yes, it should be in local space, thus it should use closetNormalLocal. Let me post a PR soon.

yangfengzzz commented 4 years ago

and in Cylinder3::closestIntersectionLocal, it use boundingBox() which is also in global space

doyubkim commented 4 years ago

PR is out

doyubkim commented 4 years ago

The fix is now merged!