search

doyubkim / fluid-engine-dev

Fluid simulation engine for computer graphics applications
https://fluidenginedevelopment.org/
MIT License
1.88k stars 263 forks source link

Add xyz file support for example apps #306

Closed doyubkim closed 4 years ago

doyubkim commented 4 years ago

This revision adds .xyz file format support for the example apps (particles2obj and particles2xml) as suggested in #303 .

utilForever commented 4 years ago

Please let me know anytime if you want to review the code. :)

doyubkim commented 4 years ago

@utilForever Thanks! I just noticed that the CMakeFiles for the example apps have meaningless msvc checks for link options. Should be removed too.

utilForever commented 4 years ago

@doyubkim I removed them. Please check! 😎

codecov-commenter commented 4 years ago

Codecov Report

Merging #306 into main will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #306   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         549      549           
  Lines       37554    37554           
=======================================
  Hits        33253    33253           
  Misses       4301     4301

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45a1882...0c7f101. Read the comment docs.

utilForever commented 4 years ago

Can I merge it? All CIs are passed.

doyubkim commented 4 years ago

@utilForever Saw your comment after merging it. Anyway it's all merged now!