laurelkeys commented 3 years ago

Noticed this when I went to double check the code, because page 27 of the book shows the return type of 2D vector cross product as Vector<T,2>, instead of being simply the scalar T:

template <typename T>
Vector<T,2> Vector<T,2>::cross(const Vector& v) const {
    return x*v.y - v.x*y;
}

codecov-commenter commented 3 years ago

Codecov Report

Merging #307 into main will increase coverage by 0.00%. The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #307   +/-   ##
=======================================
  Coverage   88.54%   88.54%           
=======================================
  Files         549      549           
  Lines       37554    37554           
=======================================
+ Hits        33252    33253    +1     
+ Misses       4302     4301    -1

Impacted Files	Coverage Δ
include/jet/vector2.h	`40.00% <ø> (ø)`
include/jet/vector3.h	`66.66% <ø> (ø)`
include/jet/vector4.h	`100.00% <ø> (ø)`
include/jet/detail/level_set_utils-inl.h	`40.29% <0.00%> (+1.49%)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update af7df69...99a7ea8. Read the comment docs.

doyubkim commented 3 years ago

Thanks for the PR! I will merge this.

doyubkim / fluid-engine-dev

Fix typo and missing newlines #307

Codecov Report