search

doyubkim / fluid-engine-dev

Fluid simulation engine for computer graphics applications
https://fluidenginedevelopment.org/
MIT License
1.9k stars 267 forks source link

No known features for CXX compiler "Clang" #318

Open Xayah-Hina opened 3 years ago

Xayah-Hina commented 3 years ago

Fluid Engine can throw a error that prevent me from a successful build on my environment (MacOS big sur, clang 11, cmake 3.19.6)

adding this line in the root CMakeLists.txt may help! (I put this line under the cmake_minimum_required(...) line)

cmake_policy(SET CMP0025 NEW)

a subtle fix advice, best regards!

utilForever commented 3 years ago

@Xayahp Thanks for report! I'll investgate this issue. ✋

utilForever commented 3 years ago

@doyubkim CMP0025 in CMake is used for the policy to use compiler ID either AppleClang or Clang. This policy was introduced in CMake version 3.0. However, our minimum version of CMake is 2.8.12. What do you think about upgrading CMake version to 3? Reference: https://cmake.org/cmake/help/latest/policy/CMP0025.html

doyubkim commented 3 years ago

I'm fine with 3.0. Let's make sure it is well documented in the readme and other docs.

utilForever commented 3 years ago

If you don't mind, I'll work on it and ready to PR within this week.

doyubkim commented 3 years ago

Sounds good to me!