search

doyubkim / fluid-engine-dev

Fluid simulation engine for computer graphics applications
https://fluidenginedevelopment.org/
MIT License
1.88k stars 263 forks source link

Make timer test more relaxed #319

Closed doyubkim closed 3 years ago

doyubkim commented 3 years ago

For some reason std::chrono::steady_clock and std::this_thread::sleep_for is not super accurate on MinGW + gcc combination. Just relaxing the test criteria a bit.

codecov-commenter commented 3 years ago

Codecov Report

Merging #319 (5e57f4c) into main (5b417c0) will not change coverage. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #319   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         536      536           
  Lines       39420    39420           
=======================================
  Hits        27068    27068           
  Misses      12352    12352
Impacted Files Coverage Δ
src/tests/unit_tests/timer_tests.cpp 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5b417c0...5e57f4c. Read the comment docs.

utilForever commented 3 years ago

@doyubkim Thanks for the fix! 😄