search

doyubkim / fluid-engine-dev

Fluid simulation engine for computer graphics applications
https://fluidenginedevelopment.org/
MIT License
1.9k stars 266 forks source link

fix python example: apic_example03.py #321

Closed PavelBlend closed 3 years ago

PavelBlend commented 3 years ago

I have fixed the error in the python example. The new version of the marchingCubes function requires 6 parameters instead of 5 (the old version of the function).

codecov-commenter commented 3 years ago

Codecov Report

Merging #321 (5df15af) into main (3d7c44e) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #321   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         536      536           
  Lines       39420    39420           
=======================================
  Hits        27068    27068           
  Misses      12352    12352

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3d7c44e...5df15af. Read the comment docs.

utilForever commented 3 years ago

Hmm... Windows-MinGW build is failed. @doyubkim I'll analyze this issue. Anyway, I think this PR is no problem to merge.

doyubkim commented 3 years ago

@utilForever Yeah it doesn't seem to be related to this PR. Please go ahead and merge it.