search

doyubkim / fluid-engine-dev

Fluid simulation engine for computer graphics applications
https://fluidenginedevelopment.org/
MIT License
1.88k stars 263 forks source link

Fix for GridSmokeSolver3 and GridSmokeSolver2 #326

Closed kentbarber closed 2 years ago

kentbarber commented 2 years ago

ComputeDiffusion was diffusing the smokeDensity grid instead of the temperature grid.

codecov-commenter commented 2 years ago

Codecov Report

Merging #326 (39a4665) into main (45b4bdb) will not change coverage. The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   68.66%   68.66%           
=======================================
  Files         536      536           
  Lines       39420    39420           
=======================================
  Hits        27068    27068           
  Misses      12352    12352
Impacted Files Coverage Δ
src/jet/grid_smoke_solver2.cpp 0.00% <0.00%> (ø)
src/jet/grid_smoke_solver3.cpp 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 45b4bdb...39a4665. Read the comment docs.

utilForever commented 2 years ago

I'll check a problem related CI failure soon. Sorry. 😢

doyubkim commented 2 years ago

Looks good! Merged.