dozmorovlab / HiCcompare

Joint normalization of two Hi-C matrices, visualization and detection of differential chromatin interactions. See multiHiCcompare for the analysis of multiple Hi-C matrices
https://dozmorovlab.github.io/HiCcompare/
Other
19 stars 3 forks source link

The vignettee's instruction for excluding CNV may need some further calrification #33

Closed xs254 closed 2 months ago

xs254 commented 2 months ago

Sorry if I raise a trivial question as I am quite new to the field of HiC. I am trying to compare the HiC results from a pair of knockout and control cell line. According to the vignettee, it is recommneded to remove CNV when generating the hic.table object. I think there are two ways to do that:

1) In the first way, I can get CNV from the KO and control group respectively by using CNV detection algorithm that does not require a referenece. And then use the union of KO_CNV and Control_CNV as the regions to exclude: exclude <-cbind(KO_CNV,Control_CNV) 2) In the second way, I can use a CNV detection algorithm that requires reference signal and use control as the reference to find the 'extra' CNV caused by KO and only exlcude the extra CNV.

Given that QDNAseq used by get_CNV does not require a reference signal, I guess approach 1) is preferred? I think it would be better if the vignettee can have more clarification on this process.

mdozmorov commented 2 months ago

I would recommend a different approach. Detect differential interactions as you normally would. Detect CNVs using any tool. Check if some boundaries, of whole interactions with both boundaries, overlap them - these are candidates for being differential due to CNVs.

One note is about CNVs - do you expect KO would introduce a lot of them? I would doubt it and won't be concerned. We've been trying various CNV detection methods only to find out many CNVs are false positives, artifacts of either the technology, alignment, or both. It can easily be seen by comparing one normal genome vs. another.

xs254 commented 2 months ago

Many thanks for the clarification! If I understand correctly, you recommend detecting CNVs separately without removing CNVs from the data for HiCcompare. The CNV detection results can be used as an extra layer of information for interpreting the differential interactions detected by HiCcompare.

Regarding whether KO would introduce a lot of CNVs. To be honest, I also doubt it, but given that this is a cancer cell line, my original incentive for CNV removal is to have an extra layer of security. However, as you have mentioned, CNV detection algorithms are prone to false positives and thus removing CNV might cause more bad than good.

On Wed, Sep 25, 2024 at 5:08 AM Mikhail Dozmorov @.***> wrote:

I would recommend a different approach. Detect differential interactions as you normally would. Detect CNVs using any tool. Check if some boundaries, of whole interactions with both boundaries, overlap them - these are candidates for being differential due to CNVs.

One note is about CNVs - do you expect KO would introduce a lot of them? I would doubt it and won't be concerned. We've been trying various CNV detection methods only to find out many CNVs are false positives, artifacts of either the technology, alignment, or both. It can easily be seen by comparing one normal genome vs. another.

— Reply to this email directly, view it on GitHub https://github.com/dozmorovlab/HiCcompare/issues/33#issuecomment-2373505052, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZWQ2P4MSRAZKVLT5C56LSTZYJ4R5AVCNFSM6AAAAABOZHIXMGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNZTGUYDKMBVGI . You are receiving this because you authored the thread.Message ID: @.***>

mdozmorov commented 2 months ago

Yes. Even if CNVs are present and result in differential interactions, that's a perfectly valid result. Closing, but please ask more if still in doubt.