search

dpa99c / cordova-custom-config

Cordova/Phonegap plugin to update platform configuration files based on preferences and config-file data defined in config.xml
317 stars 85 forks source link

cordova-custom-config and ionic cloud build problem #112

Closed luckylooke closed 7 years ago

luckylooke commented 7 years ago

Maybe you can help with this: https://github.com/driftyco/ionic-cloud-angular/issues/26

Related: https://github.com/driftyco/ionic-cloud/issues/196 https://github.com/driftyco/ionic-app-scripts/issues/876

Thanks

dpa99c commented 7 years ago

Does Ionic Cloud support plugin hook scripts? I can't find any reference in their documentation that confirms this or not.

Because Phonegap Build and Intel XDK do not and this prevents this plugin (which is comprised solely of hook scripts) from working.

luckylooke commented 7 years ago

I have found the answer: https://docs.ionic.io/services/package/#hooks They dont support hooks.. :/ But maybe you can submit your hook..

See README.md for documentation and CONTRIBUTING.md if you’d like to submit a hook.

What do you think? :)

dpa99c commented 7 years ago

This plugin consists of multiple hooks and npm dependencies so submitting a single custom hook is not going to work.

The raison d'être for this plugin is for automated customisation of the native platform projects in a local build environment. Therefore I think, if Ionic Cloud doesn't support arbitrary plugin hooks, then support for it is out-of-scope and I won't be attempting to support it.

What I will do is update the documentation to make clear the Ionic Cloud is an unsupported environment (in addition to Phonegap Build, Intel XDK and Telerik Appbuilder).

luckylooke commented 7 years ago

Ok, at least we all know now where the problem is. Thanks anyway 👍

update the documentation

can help other ionic developers coming to your plugin :)