search

dpa99c / cordova-custom-config

Cordova/Phonegap plugin to update platform configuration files based on preferences and config-file data defined in config.xml
318 stars 84 forks source link

Github dependency #145

Closed patrick-stirnemann closed 6 years ago

patrick-stirnemann commented 6 years ago

I'm submitting a ...:

Bug report

Current behavior: "npm install" fails in our build pipeline because it cannot get the plist package due to the external reference to github.

Expected behavior: Every reference in package.json should be done with a version number.

Other information: package.json (version 5.0.2) line 34: "plist": "xiangpingmeng/plist.js"

dpa99c commented 6 years ago

The reason that a Github fork of plist.js is referenced in the package.json is because the versions published to NPM contain an unresolved bug which causes issues in this plugin.

So until such time that a version of plist is published to npm which contains a fix, this plugin's package.json will continue to reference the Github repo which contains the bugfixed version.

huerlisi commented 6 years ago

According to https://github.com/TooTallNate/plist.js/pull/67#issuecomment-281022141 the referenced bug might well be fixed in the currently released version of plist.

Who could validate this?

We're expecting build failures with the current version of cordova-custom-config as we're behind a corporate proxy that prevents direct dependencies on github (we're using a local npm mirror).

Thanks for this package and all the awesome work here!

devsheder commented 6 years ago

Hi @dpa99c , I have the same problem as above : my client is behind a corporate proxy and we can't use the lastest versions of your plugin. Were you able to contact xiangpingmeng ? Do we have to fork his project ?

Thx a lot for your work, See you