custom tag gets added to xml/config.xml

[gunhaxxor]

I'm submitting a ... (check one with "x"):

• [x] bug report
• [ ] feature request
• [ ] documentation issue

Bug report

Current behavior:

I'm installing this plugin using the command ionic cordova plugin add cordova-custom-config I'm adding the following to config.xml inside the <platform name="android"> tag:

<custom-config-file target="AndroidManifest.xml" parent="/*">
  <uses-permission android:name="android.permission.CAMERA" />
</custom-config-file>

The plugin adds the permission tag to AndroidManifest.xml as expected. But, it also adds the following to the file platforms\android\app\src\main\res\xml\config.xml:

<custom-config-file target="AndroidManifest.xml" parent="/*">
  <uses-permission android:name="android.permission.CAMERA" />
</custom-config-file>

This results in the following build error when running ionic cordova run android --device:

...
C:\dev\social-robot\social-robot-ionic\platforms\android\app\src\main\res\xml\config.xml:76: AAPT: error: unbound prefix.

C:\dev\social-robot\social-robot-ionic\platforms\android\app\src\main\res\xml\config.xml:76: error: unbound prefix.

:app:mergeDebugResources FAILED

FAILURE: Build failed with an exception.

* What went wrong:
Execution failed for task ':app:mergeDebugResources'.
> Error: java.util.concurrent.ExecutionException: com.android.tools.aapt2.Aapt2Exception: AAPT2 error: check logs for details

* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.

* Get more help at https://help.gradle.org

BUILD FAILED in 2s
21 actionable tasks: 1 executed, 20 up-to-date
(node:20972) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): Error: cmd: Command failed with exit code 1 Error output:
C:\dev\social-robot\social-robot-ionic\platforms\android\app\src\main\res\xml\config.xml:76: AAPT: error: unbound prefix.

C:\dev\social-robot\social-robot-ionic\platforms\android\app\src\main\res\xml\config.xml:76: error: unbound prefix.
...

Expected behavior:

I expect that the custom-config-file tag doesn't get added to the config.xml in platforms\android\app\src\main\res\xml\

Environment information

• Cordova CLI version: 8.0.0

• Cordova platform version: Android 7.0.0

• Plugins & versions installed in project (including this plugin):

• cordova-custom-config 5.0.2 "cordova-custom-config"

• cordova-plugin-android-permissions 1.0.0 "Permissions"

• cordova-plugin-ble-central 1.2.2 "BLE"

• cordova-plugin-camera 4.0.3 "Camera"

• cordova-plugin-compat 1.2.0 "Compat"

• cordova-plugin-device 2.0.2 "Device"

• cordova-plugin-ionic-keyboard 2.1.2 "cordova-plugin-ionic-keyboard"

• cordova-plugin-ionic-webview 1.2.1 "cordova-plugin-ionic-webview"

• cordova-plugin-splashscreen 5.0.2 "Splashscreen"

• cordova-plugin-statusbar 2.4.2 "StatusBar"

• cordova-plugin-whitelist 1.3.3 "Whitelist"

• cordova.plugins.diagnostic 4.0.10 "Diagnostic"

• Dev machine OS and version: Windows 10 Version 1803

Android build issue:

• Node JS version
  • node -v
• Gradle version
  • ls platforms/android/.gradle
• Target Android SDK version
  • android:targetSdkVersion in AndroidManifest.xml
• Android SDK details
  • sdkmanager --list | sed -e '/Available Packages/q'

iOS build issue:

• Node JS version: v8.9.4

[dpa99c]

Since you are using the android XML namespace, did you declare it in the config.xml for the XML parser to reference?

For example, see the example project's config.xml

FYI cordova-android deploys the project config.xml to platforms\android\app\src\main\res\xml\config.xml in order to make the configuration available to the native Android layer.

[gunhaxxor]

Thanks for the swift answer. It seems like that indeed was the problem.