fix: android getExternalSdCardDetails on API 33 - Githubissues

dpa99c / cordova-diagnostic-plugin

Cordova/Phonegap plugin to manage device settings

539 stars 361 forks source link

fix: android getExternalSdCardDetails on API 33 #495

Closed ghenry22 closed 1 year ago

ghenry22 commented 1 year ago

android getExternalSdCardDetails on API 33 fails as the read/write external storage permissions have been removed.

Update to use the existing permissions check for API < 33, do not request the invalid permissions for API 33+

Backward compatible, non-breaking change.

PR Type

What kind of change does this PR introduce?

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation changes
[ ] Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

[X ] Testing has been carried out for the changes have been added
[ ] Regression testing has been carried out for existing functionality
[ ] Docs have been added / updated

What is the purpose of this PR?

Does this PR introduce a breaking change?

[ ] Yes
[ X] No

What testing has been done on the changes in the PR?

Tested extensively on my own projects with different API versions to validate behaviour on API below 33 and on API 33+

What testing has been done on existing functionality?

No changes to existing behaviour

Other information