search

dpa99c / cordova-launch-review

Cordova/Phonegap plugin for iOS and Android to assist in leaving user reviews/ratings in the App Stores
71 stars 26 forks source link

isRatingSupported() returns true on iPad version 9.3.5 #11

Closed Deeeej closed 6 years ago

Deeeej commented 6 years ago

Hello,

Great plugin, thanks for all the hard work.

It appears that isRatingSupported() only works correctly on the iPhone, not on the iPad Mini. It returns true in all circumstances on the iPad.

My limited knowledge in this area would suggest this is probably down to the use of the constant: IPHONE_10_3 AND IPHONE_OS_VERSION_MAX_ALLOWED in LaunchReview.m.

dpa99c commented 6 years ago

You're right on this, it has not been tested on iOS 9 before, so I'll push out a patch release to resolve this issue shortly.

dpa99c commented 6 years ago

The fix has been pushed out to npm in v3.1.1

Let me know if you still have an issue.

Deeeej commented 6 years ago

Fantastic, thanks very much. I tested it and it seems to works exactly as expected.