delciopolanco
commented
2 years ago This is how is supposed to work on dev.
Closed delciopolanco closed 2 years ago
delciopolanco
commented
2 years ago This is how is supposed to work on dev.
Bug report
CHECKLIST
[x] I have read the issue reporting guidelines
[x] I confirm this is a suspected bug or issue that will affect other users
[x] I have reproduced the issue using the example projector provided the necessary information to reproduce the issue.
[x] I have read the documentation thoroughly and it does not help solve my issue.
[x] I have checked that no similar issues (open or closed) already exist.
Current behavior:
When the modal prompt is shown there is nothing to review, this plugin only redirects to the apps's main page app store.
Expected behavior:
We should review the app as described in the google play in-app API.
Steps to reproduce:
or use the example provided by modifying the Id on the launch function like the following:
function launchreview(){ LaunchReview.launch(function (){ showAlert("Successfully launched review app"); }, function (err){ showAlert("Error launching review app: " + err); }, 'com.cbord.get'); }
Screenshots
Environment information
11.0.0cordova platform lscordova plugin lsRuntime issue
Android build issue:
v14.18.1gradle-7.2android:targetSdkVersioninAndroidManifest.xmlsdkmanager --list | sed -e '/Available Packages/q'Related code:
Console output
/Users/x/Library/Android/sdk ➜ cordova-launch-review-example git:(master) cordova run android --stacktrace Checking Java JDK and Android SDK versions ANDROID_SDK_ROOT=/Users/x/Library/Android/sdk (recommended setting) ANDROID_HOME=/Users/x/Library/Android/sdk (DEPRECATED) Using Android SDK: /Users/x/Library/Android/sdk Subproject Path: CordovaLib Subproject Path: app Warning: Mapping new ns http://schemas.android.com/repository/android/common/02 to old ns http://schemas.android.com/repository/android/common/01 Warning: Mapping new ns http://schemas.android.com/repository/android/generic/02 to old ns http://schemas.android.com/repository/android/generic/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/addon2/02 to old ns http://schemas.android.com/sdk/android/repo/addon2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/repository2/02 to old ns http://schemas.android.com/sdk/android/repo/repository2/01 Warning: Mapping new ns http://schemas.android.com/sdk/android/repo/sys-img2/02 to old ns http://schemas.android.com/sdk/android/repo/sys-img2/01 > Task :CordovaLib:compileDebugJavaWithJavac FAILED FAILURE: Build failed with an exception. * What went wrong: Execution failed for task ':CordovaLib:compileDebugJavaWithJavac'. > Could not find tools.jar. Please check that /Library/Internet Plug-Ins/JavaAppletPlugin.plugin/Contents/Home contains a valid JDK installation. * Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights. * Get more help at https://help.gradle.org Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0. Use '--warning-mode all' to show the individual deprecation warnings. See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings BUILD FAILED in 2s 19 actionable tasks: 3 executed, 16 up-to-date Command failed with exit code 1: /Users/x/Projects/company/POCS/cordova-launch-review-example/platforms/android/gradlew cdvBuildDebug -b /Users/x/Projects/company/POCS/cordova-launch-review-example/platforms/android/build.gradle
``` // Paste any relevant JS/native console output here function launchreview(){ LaunchReview.launch(function (){ showAlert("Successfully launched review app"); }, function (err){ showAlert("Error launching review app: " + err); }, 'com.cbord.get'); } ```**Other information:** Please update graddle version if possible.