search

dpa99c / cordova-launch-review

Cordova/Phonegap plugin for iOS and Android to assist in leaving user reviews/ratings in the App Stores
71 stars 26 forks source link

com.google.android.play:core 1.8.0 deprecation #34

Open globules-io opened 2 months ago

globules-io commented 2 months ago

Bug report

com.google.android.play:core needs to be updated to implementation 'com.google.android.play:review:2.0.1'

As per Google Play Console

com.google.android.play:core has added this note for core:1.8.0:

If your app is targeting SDK 34+ (targetSdkVersion), then the PlayCore SDK is outdated and will likely cause crashes in your app! Please update: https://developer.android.com/guide/playcore#playcore-migration

Direct link https://developer.android.com/guide/playcore#java-kotlin-in-app-review

kinggolf commented 2 months ago

We just received notice from PlayStore that this is not compatible with Android 14. May have to switch the https://github.com/capacitor-community/in-app-review. Looks like this would work:

    googleAndroidPlayCoreVersion = project.hasProperty('googleAndroidPlayCoreVersion') ? rootProject.ext.googleAndroidPlayCoreVersion : '1.10.3'
    googleAndroidPlayReviewVersion = project.hasProperty('googleAndroidPlayReviewVersion') ? rootProject.ext.googleAndroidPlayReviewVersion : '2.0.1'
dpa99c commented 2 months ago

Should be resolved in v4.1.0 by merge of PR #36