dpa99c / cordova-plugin-firebasex

Cordova plugin for Google Firebase
MIT License
570 stars 457 forks source link

Add Consent Mode v2 (Android & iOS) #878

Closed pinguluk closed 3 weeks ago

pinguluk commented 1 month ago

PR Type

What kind of change does this PR introduce?

PR Checklist

Please check your PR fulfills the following requirements:

Bugfixes:

New features/enhancements:

What is the purpose of this PR?

GA4 now requires consent (EEA) https://support.google.com/analytics/answer/14275483

Does this PR introduce a breaking change?

What testing has been done on the changes in the PR?

Forked the firebasex test project and tested the consent functionality https://github.com/pinguluk/cordova-plugin-firebasex-test

What testing has been done on existing functionality?

Other information

pinguluk commented 3 weeks ago

I've also updated iOS sdk to 10.24.0 and bumped up Android sdks versions

dpa99c commented 3 weeks ago

Thanks, I'm going to try to make some time next week to merge this and some other PRs, fix some niggling bugs and get a release out

pinguluk commented 3 weeks ago

Thanks, I'm going to try to make some time next week to merge this and some other PRs, fix some niggling bugs and get a release out

Hey, thanks for your contribution. Can you please check if my modifications are correct? Because I don't really know Objective-c and I had to rely on your previous code, to add the new features.

Also I had to downgrade GoogleSignIn back to 6.2.4, because v7.0.0+ requires some code migration and I don't know exactly what modifications I need to do in the FirebasePlugin.m, to get this to work