search

dpa99c / cordova-plugin-request-location-accuracy

Cordova/Phonegap plugin for Android and iOS to request enabling/changing of Location Services by triggering a native dialog
96 stars 62 forks source link

Use always last version of play services location #47

Closed ComeBurguburu closed 6 years ago

ComeBurguburu commented 6 years ago

PR Type

What kind of change does this PR introduce?

Since the release of play-services 12.0 this plugin cause build issue with other plugin using a different library version cordova-plugin-request-location-accuracy use google-play-services 11.+ cordova-plugin-firebase use google-play-services 12.0

The solution is to use the last google-play-services library available com.google.android.gms:play-services-location:+

dpa99c commented 6 years ago

Thanks for submitting this, however it's not always preferable to use the most recent version of Play Services. For instance, v12.0.0 contained a bug which caused Cordova builds to fail (hence why 11.+ is still pinned by this plugin), although this has now been fixed by v12.0.1. Gradle versioning also means that by specifying +, alpha or beta releases may be pulled into the build.

Since the specified version must align with the versions specified by other plugins, the best approach is to override the version specified by this and other plugins using cordova-android-play-services-gradle-release to align the versions between plugins and this enables you to specify exactly which version you desire.