dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows
369 stars 131 forks source link

Launch Navigator 4.0.1 and 4.0 crashes(?) on iOS 9.x #141

Closed petkoe closed 7 years ago

petkoe commented 7 years ago

Hello,

I use Launch Navigator with ionic 3.5.3 and native 4.0.

this.launchNavigator.navigate("street 5, city");

In 11 beta it works as expected but in 9.3 and older it starts testing for url schemes for the apps to use and does not come to an end / crashes.

Regartds

Peter

dpa99c commented 7 years ago

it starts testing for url schemes for the apps to use

By this, I would assume you mean this type of message is displayed:

-canOpenURL: failed for URL: "citymapper://" - error: "(null)"

They are automated messages generated by the native canOpenURL function when the plugin attempts to detect which apps are installed. The only way this can be done on iOS is to try to invoke the associated URL scheme for the app. If it succeeds, we know the app is installed. If it fails, we know the app is not installed on the device and also a message like this is generated in the Xcode console output.

and does not come to an end / crashes.

Try building+running one of the apps in the example project to eliminate the possibility of a bug in your implementation. I've just tested the AdvancedExample project on an iPad 2 running iOS 9.3.5 and an iPad Air 2 running iOS 10.3 and it works fine.

If there was a native crash, in the example app, please post the stack trace that is displayed in the Xcode debugger pane.

petkoe commented 7 years ago

Hi Dave,

I tried the Ionic3Example with the default plugin v 3.2.2 which worked fine. After updating to 4.0.1 (removing and adding it) the navigation goes in an endless loop of "-canOpenUrl .." messages. I tested it with a device on 11.0 (latest dev beta) and on simulators with Xcode 8.3.3 and Xcode 9 beta. On the 11 betas everything works as expected but the 9.3 (and on an real iPhone se) just loops endless. I have the same code since last year, just updated everything to the latest versions, I can give you my code if you like, but it is most likely a problem with the version 4

dpa99c commented 7 years ago

Hi Peter, OK thanks for the extra info. I'll test Ionic3Example on iOS 9. Maybe there's an issue between the plugin and the Ionic Native wrapper. I'll investigate and let you know. If necessary, I'll push out v4 patch release to fix any bug I find.

petkoe commented 7 years ago

OK, if you need any testing or more info, contact me. Thanks Peter

dpa99c commented 7 years ago

Should be fixed by #137 which has been published as uk.co.workingedge.phonegap.plugin.launchnavigator@4.0.2.

The bug only occurred when 1 supported app is available on the device, hence I missed it in testing as all of my test devices have more that 1 supported app installed.

petkoe commented 7 years ago

Hello Dave,

that did it. Thanks for the quick solution. And thanks for your work.

Peter