dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows
369 stars 131 forks source link

Start location is of no use #145

Closed abdul-basit0 closed 7 years ago

abdul-basit0 commented 7 years ago

When i create a build or use the same code for navigation between two locations, it ignores the start location and use current location instead.

dpa99c commented 7 years ago

This is not enough information: for example which navigation apps are encountering the issue, what plugin version, what platform?

This plugin has been thoroughly regression tested, so most likely you are specifying the wrong input parameter for start location. Please see the example repo which contains several Cordova projects which illustrate how to use the plugin, for example the SimpleExample shows how to specify the start location. Please try building and running the example projects to validate this.

abdul-basit0 commented 7 years ago

Sir i have even created the build of your code but its not working as shown in demo..

abdul-basit0 commented 7 years ago

It doesn't even bother what is in the "Start" variable

dpa99c commented 7 years ago

Please give the following info:

Platform: Android or iOS? Plugin version? (e.g. 4.0.3) Navigation app? (e.g. Google Maps) Plugin interface? (Ionic Native or pure JS)

Code example of your call to the plugin, for example:

launchnavigator.navigate(dest, {
    start: start,
    enableDebug: true
});
abdul-basit0 commented 7 years ago

Platform : Android Navigation app: Google Maps Plugin interface: Ionic 2

downloaded it from here https://ionicframework.com/docs/native/launch-navigator/

dpa99c commented 7 years ago

OK, I will have a look at this when I get some time. It may be a bug in the Ionic Native wrapper for this plugin.

dpa99c commented 7 years ago

It looks like this is being caused by mismatch in how parameters are mapped between ionic-native@4 and this plugin. These easiest thing is for me to create a patch release of the plugin which will map the ionic-native parameter structure to the structure expected by this plugin.

dpa99c commented 7 years ago

I've just published a patch release - v4.0.4 - which fixes this issue when using the plugin with Ionic Native v4.