fixes for cordova-android@7

dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows

369 stars 131 forks source link

fixes for cordova-android@7 #188

Closed bdirito closed 6 years ago

bdirito commented 6 years ago

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation changes
[ ] Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

[x] Testing has been carried out for the changes have been added
[ ] Regression testing has been carried out for existing functionality
[ ] Docs have been added / updated

What is the purpose of this PR?

cordova-android^7 changes their file structure such that references to AndroidManifest.xml need to be replaced with app/src/main/AndroidManifest.xml. See https://cordova.apache.org/announcements/2017/12/04/cordova-android-7.0.0.html

Does this PR introduce a breaking change?

[x] Yes
[ ] No

dpa99c commented 6 years ago

This change is unnecessary as cordova-android@7 automatically resolves target="AndroidManifest.xml" to platforms/android/app/src/main/AndroidManifest.xml so the current configuration works fine with cordova-android@7 and earlier versions.

By changing it to target="app/src/main/AndroidManifest.xml", this means the plugin will no longer work with cordova-android@6 which is still in common use at this time.