Fix launching HERE Maps if destName is null - Githubissues

dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows

369 stars 131 forks source link

Fix launching HERE Maps if destName is null #216

Closed marceldoering closed 5 years ago

marceldoering commented 5 years ago

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation changes
[ ] Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

[ ] Testing has been carried out for the changes have been added
[ ] Regression testing has been carried out for existing functionality
[ ] Docs have been added / updated

What is the purpose of this PR?

If destName is not set and therefore null, HERE Maps will not launch.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

dpa99c commented 5 years ago

Thanks, I have applied this to all string checks.