dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows
369 stars 129 forks source link

Incompatability when using Xcode 11.6 between this plugin and cordova-plugin-network-information #248

Closed fuzails closed 3 years ago

fuzails commented 3 years ago

Bug report

CHECKLIST

Current behavior:

Using Xcode 11.6 Cannot compiile the project with version 5.0.4 of launch navigator, Compilation error is

On lines 14 - 18 of LN_Reachabilty.h NetworkStatus ` typedef enum : NSInteger { NotReachable = 0, ReachableViaWiFi, ReachableViaWWAN } NetworkStatus;

`

On the Latest versin of Xcode this plugin is no longer compatible with the cordova-plugin-network-information plugin. Would it n ot be better to utilise the cordova-plugin-network-information as a dependency to this plugin instead?

Expected behavior:

Cocoa Pods should compile

Steps to reproduce:

Install both: cordova-plugin-network-information and uk.co.workingedge.phonegap.plugin.launchnavigator

Environment information

iOS build issue:

fuzails commented 3 years ago

This can actually be easily solved by just renaming the NetworkStatus enum I believe

fuzails commented 3 years ago

I added a PR which just does the simple rename of NetworkStatus to NetStatus to avoid the conflict on the new version f iOS. Have a look at PR #251