PR for Issue #248, to remove clash the cordova-plugin-network-information - Githubissues

dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows

369 stars 129 forks source link

PR for Issue #248, to remove clash the cordova-plugin-network-information #251

Closed fuzails closed 3 years ago

fuzails commented 3 years ago

PR Type

What kind of change does this PR introduce?

[x ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x ] Refactoring (no functional changes, no api changes)
[ ] Documentation changes
[ ] Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

[ ] Testing has been carried out for the changes have been added
[ ] Regression testing has been carried out for existing functionality
[ ] Docs have been added / updated

What is the purpose of this PR?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

dpa99c commented 3 years ago

Hi, thanks for this PR. I decided it's best to prefix the NetworkStatus enum with the LN_ namespace (https://github.com/dpa99c/phonegap-launch-navigator/commit/d9a219cfe2bfa2b3bf697ba5afd978248306dab0) just in case another plugin uses NetStatus which would again conflict.