ghost
commented
3 years ago DeepCode's analysis on #edfdf9 found:
- :warning: 2 warnings, :information_source: 2 minor issues. :point_down:
Top issues
| Description | Example fixes |
|---|---|
| Comparing a string (from string literal "prompt") and a boolean (from boolean literal true) with strict operator is pointless, they can never be equal. Occurrences: | :wrench: Example fixes |
| The function defined here has no return statements and hence always returns undefined, but it is called here and its return value is used here. Occurrences: | :wrench: Example fixes |
| The expression inside debug will be computed even if the log level is not high enough for the message to be logged. This will slow the application down in vain. Consider checking the log level before evaluating the expression. Occurrences: | :wrench: Example fixes |
PR Type
What kind of change does this PR introduce?
PR Checklist
For bug fixes / features, please check if your PR fulfills the following requirements:
What is the purpose of this PR?
Add Sygic Navigation (enterpise edition) integration (Android Only) Fix Sygic extras parameters template (Android Only).
Does this PR introduce a breaking change?
What testing has been done on the changes in the PR?
This change was tested to navigate to one point and set the back_button (https://www.sygic.com/developers/professional-navigation-sdk/android/faq/how-to-program-back-button).
What testing has been done on existing functionality?
This change was tested to navigate to one point and set the back_button (https://www.sygic.com/developers/professional-navigation-sdk/android/faq/how-to-program-back-button).
Other information