dpa99c / phonegap-launch-navigator

Phonegap/Cordova plugin which launches native route navigation apps for Android, iOS and Windows
369 stars 129 forks source link

Issues with Xcode 12.3 / Redefinition of enumerator & Expected identifier or '(' #258

Closed patrickbussmann closed 3 years ago

patrickbussmann commented 3 years ago

Bug report

CHECKLIST

Current behavior:

❌  /Users/vagrant/git/ios/capacitor-cordova-ios-plugins/sources/Uk.co.workingedge.phonegap.plugin.launchnavigator/LN_Reachability.h:15:5: redefinition of enumerator 'NotReachable'
    NotReachable = 0,
        ^
❌  /Users/vagrant/git/ios/capacitor-cordova-ios-plugins/sources/Uk.co.workingedge.phonegap.plugin.launchnavigator/LN_Reachability.h:16:5: redefinition of enumerator 'ReachableViaWiFi'
    ReachableViaWiFi,
        ^
❌  /Users/vagrant/git/ios/capacitor-cordova-ios-plugins/sources/Uk.co.workingedge.phonegap.plugin.launchnavigator/LN_Reachability.h:17:5: redefinition of enumerator 'ReachableViaWWAN'
    ReachableViaWWAN
        ^
❌  /Users/vagrant/git/ios/capacitor-cordova-ios-plugins/sources/Uk.co.workingedge.phonegap.plugin.launchnavigator/LN_Reachability.h:24:18: expected identifier or '('
extern NSString *kReachabilityChangedNotification;

iOS build issue:

There was an issue in the past with the redefinition thing.

248 #251

When I have time I'll fix this issue here, too.

zieemer commented 3 years ago

Hi Any ideas when fix might be ready ?

blhylton commented 3 years ago

Had to work through this in short order for a quick turnaround project. Created a PR with the updates.

j3gb3rt commented 3 years ago

Our team is facing this issue also. @blhylton Thanks for the patch! Looking forward to this being released

gabides commented 2 years ago

Hi @dpa99c, do you plan to release a new version soon on npm with these changes? That would be quite helpful to have a stable build on our ios version :) Thanks

vivek365 commented 2 years ago

I am facing the same issue. Is there any chance to release a new version in near future with this fix? Or Can I do any work around to fix this issue now?

Thanks

dpa99c commented 2 years ago

The current master branch has been released to npm as uk.co.workingedge.phonegap.plugin.launchnavigator@5.0.6

vivek365 commented 2 years ago

thanks @dpa99c