--fix Use project's minSdkVersion if available - Githubissues

dpa99c / react-native-launch-navigator

A React Native module for launching today's most popular navigation/ride apps to navigate to a destination.

143 stars 34 forks source link

--fix Use project's minSdkVersion if available #18

Closed bencergazda closed 5 years ago

bencergazda commented 5 years ago

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation changes
[ ] Other... Please describe:

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

[ ] Testing has been carried out for the changes have been added
[ ] Regression testing has been carried out for existing functionality
[ ] Docs have been added / updated

What is the purpose of this PR?

See #17

Does this PR introduce a breaking change?

[ ] Yes
[x] No

What testing has been done on the changes in the PR?

What testing has been done on existing functionality?

Other information

RuudBurger commented 5 years ago

Can this get merged? Fix works for me

RuudBurger commented 5 years ago

That's what I call quick service ;)

bencergazda commented 4 years ago

@dpa99c Just a friendly ping, are you planning to publish a new release containing this merged PR in the near future?