dpa99c / react-native-launch-navigator

A React Native module for launching today's most popular navigation/ride apps to navigate to a destination.
143 stars 34 forks source link

androidx #28

Closed Azshar closed 4 years ago

Azshar commented 4 years ago

Hello, you can add support androidx in this project?

dpa99c commented 4 years ago

This module does not use the legacy Android Support Library so there is no need to migrate it to use the replacement AndroidX library.

Therefore it should work fine in Android projects that use either the Android Support Library or AndroidX.

dpa99c commented 4 years ago

No, I am wrong, it does use the Android Support Library for android.support.annotation.Nullable.

I'll see whether this can be removed entirely otherwise updated to use AndroidX

hb2708 commented 4 years ago

@dpa99c @Azshar so this is solved or not?

dpa99c commented 4 years ago

No it's still referencing the Android Support Library.

Apologies, I've been busy with other stuff and no longer use this library myself, so it needs some love - PRs welcome.

hb2708 commented 4 years ago

PR will be there in 2 minutes

dpa99c commented 4 years ago

Fixed by #30 (thanks to @hb2708)

hb2708 commented 4 years ago

@dpa99c can this be released also coz i am in middle of migration to react-native 0.59.x to 0.60.x?

dpa99c commented 4 years ago

@hb2708 I think #29 needs resolving first before I can do a release. I last tested this module with RN v0.60.4 so I think something in 0.61 or 0.62 has caused it to break with those versions.

dpa99c commented 4 years ago

You can install it direct off the master branch of this repo in the meantime

hb2708 commented 4 years ago

You doing that for now Might create a new pr again for #29 when i go to 0.61 / 0.62

NeerajNegi commented 4 years ago

Changing the import to import androidx.annotation.Nullable; should do.

hb2708 commented 4 years ago

@NeerajNegi it's solved already and the fix is there on master

NeerajNegi commented 4 years ago

But I see that in npm last publish was 6 months ago and this issue was fixed 3 months ago. Is this fix not available in npm ?