dpa99c / react-native-launch-navigator

A React Native module for launching today's most popular navigation/ride apps to navigate to a destination.
143 stars 34 forks source link

Android 11 (API 30) target support #38

Closed caioiglesias closed 2 years ago

caioiglesias commented 2 years ago

Calls to LaunchNavigator.getAvailableApps() were returning false for all supported apps. An update do the manifest is required in order to query for other packages. https://developer.android.com/training/package-visibility/declaring

PR Type

What kind of change does this PR introduce?

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

What is the purpose of this PR?

The purpose is to fix calls to LaunchNavigator.getAvailableApps(). All supported apps by the lib were returning false even when they were available.

Does this PR introduce a breaking change?

What testing has been done on the changes in the PR?

I rebuilt my own project with the changes and the method that was returning wrong data now works. There's no need to update any sample project.

What testing has been done on existing functionality?

This PR shouldn't affect any existing functionality.

Other information

caioiglesias commented 2 years ago

Hi @dpa99c I created this PR some time ago, maybe it went under the radar because I didn't create an issue with it. Do you need one?

dpa99c commented 2 years ago

Hi @dpa99c I created this PR some time ago, maybe it went under the radar because I didn't create an issue with it. Do you need one?

Nope, sorry I missed this