add setGoogleApiKey in ts definition - Githubissues

dpa99c / react-native-launch-navigator

A React Native module for launching today's most popular navigation/ride apps to navigate to a destination.

143 stars 34 forks source link

add setGoogleApiKey in ts definition #40

Closed jbcrestot closed 1 year ago

jbcrestot commented 1 year ago

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation changes
[x] Other... Please describe: fix type definition

PR Checklist

For bug fixes / features, please check if your PR fulfills the following requirements:

[ ] Testing has been carried out for the changes have been added
[ ] Regression testing has been carried out for existing functionality
[ ] Docs have been added / updated

What is the purpose of this PR?

related to issue : https://github.com/dpa99c/react-native-launch-navigator/issues/39

setGoogleApiKey will now be available for typescript users

Does this PR introduce a breaking change?

[ ] Yes
[x] No

What testing has been done on the changes in the PR?

none

What testing has been done on existing functionality?

none

Other information

jbcrestot commented 1 year ago

Thanks @dpa99c for the merge. Would you mind push a new tag on npm 🙏 ?