search

dpacassi / disable-javascript

Adds the ability to disable JavaScript on specific sites.
MIT License
275 stars 36 forks source link

Separate Blacklist from Whitelist #22

Open kaaylim opened 6 years ago

kaaylim commented 6 years ago

Hi @dpacassi , thank you for your work.

If I understand correctly the current version only has 1 list which revert the default behaviour. This is inconvenient when we toggle this default, since all the domains enabled/disabled have now the opposite setting.

It would make more sense to have black-listed and white-listed domains.

dpacassi commented 6 years ago

Thanks for the report!

The web extension currently only supports one list, that's correct. It was developed like this to minimize code complexity since users probably set their whitelist/blacklist approach only once and stick with that decision.

However, I'll apporach this together with #18, as soon as I'll have to rewrite those code parts. I wouldn't count with this feature in the near future though (Pull requests are welcome though!)

Crissov commented 5 years ago

Since this was not clear to me at first, you should probably alter the heading accordingly, i.e. where it currently says Domain list, it should read Domain whitelist if Javascript is off by default and Domain blacklist otherwise.