search

dpacassi / disable-javascript

Adds the ability to disable JavaScript on specific sites.
MIT License
272 stars 33 forks source link

Keyboard shortcuts don't work in Vivaldi browser #30

Closed stealzy closed 6 years ago

stealzy commented 6 years ago

Great extension, thank you! But only accessible by mouse for me, so I must keep extension panel unhided. Also it would be cool ability to change shortcuts.

dpacassi commented 6 years ago

Hi @stealzy

It seems like the Vivaldi browser currently has a bug with shortcuts and web extensions (read e.g. this and this).

However, you can active the shortcuts. Just follow these steps:

  1. In the Vivaldi browser, open your extensions page (vivaldi://extensions)
  2. Click on the botton right on "Keyboard shortcuts"
  3. Make sure that you have all dropdowns in the popup set to "Global" and not "Vivaldi"
  4. Press OK

Now the shortcuts should work also in Vivaldi. There you can also change the shortcut keys if you desire.

The shortcuts keys can only be changed in the Vivaldi browser though. At this moment, it is not possible for web extensions to dynamically define shortcut keys. They already have to be defined in the manifest.json file, which is a static file (and the web extension API doesn't provide a function to extend/change that information).

Let me know if you have any further questions or bugs!

stealzy commented 6 years ago

Thanks for clarification and sorry for my ignorance.

dpacassi commented 6 years ago

No problem! Better to report something once too much than too few :)