search

dpacassi / disable-javascript

Adds the ability to disable JavaScript on specific sites.
MIT License
275 stars 36 forks source link

Question: If JS disabled by domain, some sites dont work #33

Closed sir-harlekin closed 6 years ago

sir-harlekin commented 6 years ago

Hi there,

maybe i am just missing something:

If i use blocking per domain for example amazon does not work. i guess its because some of the underlying domains (amazon pictures and what not) are not greenlit.

It works if i chose blocking by tab.

Is there a way to greenlight all "invisible" domains belonging to the TLD?

Kind regards

dpacassi commented 6 years ago

Hey @sir-harlekin!

Thanks for your question. Actually, if you open the web extension settings page (right click on the switch icon and select Open Disable JS settings, you can remove the www.amazon.com entry and add a amazon.com entry with Include sub-domains? checked. That way you can whitelist/blacklist all subdomains belonging to one TLD.

This should solve your issue. However, I find it interesting that Amazon works for you if you block things by tab but not if you block it via domain. For me it works in both cases. And reviewing my code, there's no difference in how to block JS for either case.

I would like to inspect this behavior a bit more. Could you please define which Amazon URL does not work for you if you disable JS by domain? And maybe not just the URL but also what exactly you expect to work (which functionality). Also, a screenshot of your Disable JavaScript settings would be great :)

Thanks for your help!

ugulz commented 6 years ago

I have same problem with some sites not fully working if using "by domain". It only work properly if using "by tab" or disabling extension altogether. The one I was just using was ebay.com.au creating a listing the add photo dialog not showing. Another site it was one of those recaptcha pic select things not showing

dpacassi commented 6 years ago

@ugulz Could you please provide me the exact steps on how to reproduce the issue? Something like

  1. Start Firefox/Chrome
  2. Go to the site www.domain.com
  3. Click on the link "Example"
  4. This site is not working

In addition, please specify which browser you are using and a screenshot of your Disable JavaScript settings would also be great.

I know it's a lot on information I ask for but I can't reproduce the bug on my Windows nor on my Mac machine. Thanks a lot for your support!

dpacassi commented 6 years ago

Also, please update to the web extension version 2.3.1. I've published it today, it may take up to one day for your browser to update it. Let me know if you're still experiencing any issues after the update and if so, how I can reproduce the issue, thanks a lot!

ugulz commented 6 years ago

its only a problem when using as whitelist. Some site load another document from another domain and scripts called from that doc aren't running unless manually add that domain to whitelist. I guess its same issue as iframe enhancement you mention in another post

dpacassi commented 6 years ago

@ugulz Unfortunately I can't reproduce the described issue. Here's what I've tried:

So, when allowing a site through the web extension, it will allow that site to load external JavaScript as well. What's not handled is if the site has iframes integrated ( https://github.com/dpacassi/disable-javascript/issues/41 ).

I'm therefor closing this issue. If you still experience a bug though, please open a new issue describing on how to exactly reproduce the error. Thanks!