search

dpacassi / disable-javascript

Adds the ability to disable JavaScript on specific sites.
MIT License
272 stars 33 forks source link

hotkeys on mac conflict with € sign #45

Open Ken-B opened 5 years ago

Ken-B commented 5 years ago

For us europeans, it's quite unfortunate that our currency sign hotkey (alt+shift+2) is the same as the hotkey for this extension.

Imagine that every time you type $ somewhere in an email or google doc, your javascript settings page comes up.

I've disabled hotkeys for now., but perhaps it's an idea to make this hotkey configurable?

Anyway, thanks for this very nice plugin!

dpacassi commented 5 years ago

Hey @Ken-B!

Thanks for your input! Unfortunately it's not possible to customize hotkeys for web extensions right now and we already had trouble finding a shortcut which works across browsers and operating systems (see #4). I would therefor like to keep the current shortcuts.

I'm located in Europe myself and I have to type AltGr + E to get the € sign. If you're located in Belgium and http://eurosymbol.eu/keyboard is right, you should be able to type it with AltGr + E or Ctrl + Alt + E? (Note: On Mac it's Alt + E!)

Is that correct? Maybe switching to one of these shortcuts may be the solution. According to https://addons.mozilla.org/en-US/firefox/addon/disable-javascript/statistics/usage/languages/?last=30 I have lots of German and French users, none of them complained so far. So I guess for the majority the shortcuts work/don't conflict with any existing ones.

Ken-B commented 5 years ago

Hi David,

Thanks for your answer! I'm on an qwerty keyboard on mac, as I believe many programmers are (all my colleagues here in Belgium use qwerty). I use qwerty because of the easy accesable keys for ~ ` . { } $ ^ | etcetera that need special combo's on european keyboards.

On mac there's no AltGr key. The (left and right) Alt + E give the ´ (backtick) sign (the backtick hangs with lower Alt+e to allow for é or á symbols, it sticks with Alt + Shift + e).

On qwerty, the combination for euro sign is Alt + Shift + 2, see e.g. google or stackoverflow.

Your French (azerty) and German (qwertz) users will have the special key on their keyboard if they don't use qwerty. And probably your US users don't need to type the € sign.

So I guess I'm a special case and I will disable the hotkeys. Clicking on it works fine too :)

Thanks again for this very nice plugin.

Best Ken