search

dpacassi / disable-javascript

Adds the ability to disable JavaScript on specific sites.
MIT License
272 stars 33 forks source link

Separate "allowed" and "blocked" lists #69

Closed heatherbooker closed 4 years ago

heatherbooker commented 4 years ago

Hi!

It seems like there is only 1 list of "exceptions", which behaves differently depending on whether you have JS disabled or enabled by default. However, if you change the default (from disabled to enabled), all those sites stay on the list, and now they are exceptions in the opposite direction! >< Which is a bit odd.

Perhaps I am the odd one for changing the default but I'm still playing around to see what works best, and I'd love to be able to track 2 separate lists, one of "allowed" domains for when JS is disabled by default, and one of "blocked" domains for when JS is enabled by default.

Thanks for your time developing this extension! ^^

heatherbooker commented 4 years ago

I'm not sure what would be a good way to reflect this in the UI, here's my thoughts:

  1. Add a column to the table listing the exceptions
  2. Show 2 separate lists of exceptions
    • stacked
    • side by side
    • toggle which one shows by a tab/button

When users manually add an exception, should they be able to specify which type they are entering?

For me, I don't think I would care about the UI so much, really just the functionality.

heatherbooker commented 4 years ago

Oh I somehow didn't find #22 which this duplicates when I was looking for issues. Sorry I'll close this! ><