search

dpallot / simple-websocket-server

A python based websocket server that is simple and easy to use.
951 stars 321 forks source link

HTTP server gets opened with "import *" #73

Closed The-Compiler closed 5 years ago

The-Compiler commented 6 years ago

When doing from SimpleWebSocketServer import *, SimpleHTTPSServer.py is executed as well, which opens a HTTP server on localhost when imported.

The code in there should probably be guarded by a main-clause to not do that, and __all__ should be set properly for the package.

See https://www.reddit.com/r/vim/comments/86hnfk/if_you_have_used_or_are_using_vimghost_you_should/

dpallot commented 5 years ago

4a9defa176919142d4bf738d307fb77fea0a04ad

The-Compiler commented 5 years ago

More like d49f2e6aafc53f591e7f4547da4c7311b2058ebb :wink: