dpalmasan / TRUNAJOD2.0

An easy-to-use library to extract indices from texts.
https://trunajod20.readthedocs.io/en/latest/
MIT License
29 stars 7 forks source link

Added typehints following doctype that return types are all floats T… #47

Closed BrandonGoding closed 3 years ago

BrandonGoding commented 3 years ago

32 Added type hints following doctypes that return values are floats. Ran testss and they all passed

dpalmasan commented 3 years ago

Looks good! Could you add the following for the constructor?

In imports:

from spacy.tokens import Doc
from typing import Dict
from typing import Optional

Then in the constructor:

def __init__(self, doc: Doc, lemmatizer: Optional[Dict[str, str]]=None):

Thanks!

dpalmasan commented 3 years ago

You might need to install the pre-commits to avoid the lint errors, which will automatically fix the lint issues on commit, or just use the output from the Lint stage to fix the lint fail.

BrandonGoding commented 3 years ago

You might need to install the pre-commits to avoid the lint errors, which will automatically fix the lint issues on commit, or just use the output from the Lint stage to fix the lint fail.

Thanks, that was the key! This was a fun little project to learn how pull requests work. Thanks for the oppertunity

dpalmasan commented 3 years ago

Sure! Merging, thanks for the commit!