dpaperno / DiscriminAtt

BSD 2-Clause "Simplified" License
15 stars 9 forks source link

UnboundLocalError in evaluation.py #4

Closed omidrohanian closed 6 years ago

omidrohanian commented 6 years ago

In the evaluation file, f1_positivesand f1_negatives are defined within conditionals. I think it is better if they are initialized beforehand as this might cause UnboundLocalError on line 31. Those conditions cannot both hold true all the time (e.g. a system that produces zero true positives but a lot of true negatives).

dpaperno commented 6 years ago

Thank you Omid, we have fixed this following your suggestion!