search

dparrini / python-comtrade

A module designed to read Common Format for Transient Data Exchange (COMTRADE) file format.
MIT License
80 stars 41 forks source link

Issues with type conversation (again) #11

Closed mathiasrabe closed 3 years ago

mathiasrabe commented 3 years ago

I have an issue with type conversation (again). I allready commented it in https://github.com/dparrini/python-comtrade/issues/2#issue-434918587

It seems that a new commit changed the type conversation back to this:

https://github.com/dparrini/python-comtrade/blob/78a4903fd6d1f3253097f18c8ff5b04be3c5ec62/comtrade.py#L387-L388

As you allready mentioned in https://github.com/dparrini/python-comtrade/issues/2#issue-434918587 the data type can be float too.

dparrini commented 3 years ago

HI @mathiasrabe you're correct, I mentioned this, but I think in the previous issue I only fixed the skew problem (in that case skew could also be empty). I'm fixing this now.

dparrini commented 3 years ago

Fixed with the last commit: 1778e90c845cdc707adddf2552ecc42930677bfb Please tell me if its working for you.

mathiasrabe commented 3 years ago

It's working. Thanks!