search

dparrish / libcli

Libcli provides a shared library for including a Cisco-like command-line interface into other software. It's a telnet interface which supports command-line editing, history, authentication and callbacks for a user-definable function tree.
https://dparrish.com/link/libcli
GNU Lesser General Public License v2.1
296 stars 147 forks source link

Patch against libcli 1 10 0 rel2 #51

Closed RobSanders closed 5 years ago

RobSanders commented 5 years ago

Fix bug if command is either all spaces or there are only spaces after a '|' character.

RobSanders commented 5 years ago

Will fix. Was on the fence on that… -R

-- ROBERT SANDERS Sr. Secure Systems Engineer

FORCEPOINT T +1.703.896.4762 F +1.703.318.5041 www.forcepoint.com

FORWARD WITHOUT FEAR

From: David Parrish notifications@github.com Reply-To: dparrish/libcli reply@reply.github.com Date: Wednesday, August 21, 2019 at 7:18 PM To: dparrish/libcli libcli@noreply.github.com Cc: Rob Sanders rsanders@forcepoint.com, Author author@noreply.github.com Subject: EXTERNAL: Re: [dparrish/libcli] Patch against libcli 1 10 0 rel2 (#51)

@dparrish commented on this pull request.

In libcli.spechttps://github.com/dparrish/libcli/pull/51#discussion_r316440798:

@@ -1,7 +1,7 @@

Version: 1.10.1

Summary: Cisco-like telnet command-line library

Name: libcli

-Release: 1

+Release: 2

As a bug fix I think this should be 1.10.2, rather than release-2. The Release number is an RPM spec feature, not a version number. From https://rpm-packaging-guide.github.io/: "The number of times this version of the software was released. Normally, set the initial value to 1%{?dist}, and increment it with each new release of the package. Reset to 1 when a new Version of the software is built."

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://github.com/dparrish/libcli/pull/51?email_source=notifications&email_token=AHHFTFYCISWYL27HLUEVYOTQFXEKZA5CNFSM4IOOHNQKYY3PNVWWK3TUL52HS4DFWFIHK3DMKJSXC5LFON2FEZLWNFSXPKTDN5WW2ZLOORPWSZGOCCJ427Y#pullrequestreview-278121855, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHHFTF2EYS63BXX4SZCTOKTQFXEKZANCNFSM4IOOHNQA.