search

dpaukov / combinatoricslib3

Combinatorial objects stream generators for Java.
Apache License 2.0
177 stars 24 forks source link

Added generation of combinations based from lists #5

Closed juliusiglesia closed 6 years ago

juliusiglesia commented 6 years ago

Fixes #4

Changes:

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.1%) to 98.778% when pulling dd6a907a528f6173f687f5313708fa797072c843 on juliusiglesia:master into 7068cb6d652613c6b5387129124e78109e7997f9 on dpaukov:master.

dpaukov commented 6 years ago

Hello, Julius!

Thank you for implementing this generator.

It produces Cartesian Product of the lists. I think we should rename it to something like CartesianProductGenerator.java and CartesianProductIterator.java to make it clear of what it does.

https://en.wikipedia.org/wiki/Cartesian_product

juliusiglesia commented 6 years ago

Helllo Dmytro,

Fixed the following:

Thank you.

dpaukov commented 6 years ago

Thank you, Julius, for doing this.