Fix warning about missing default codecs on first run

dpaulat / supercell-wx

Supercell Wx is a free, open source advanced weather radar viewer.

https://supercell-wx.rtfd.io

MIT License

85 stars 14 forks source link

Fix warning about missing default codecs on first run #223

Closed aware70 closed 3 weeks ago

aware70 commented 4 weeks ago

I'm packaging Supercell Wx for NixOS/nixpkgs (see: https://github.com/NixOS/nixpkgs/pull/316266) and I noticed that on first run I get a warning about missing default codecs, even though I have the codecs in question installed. The audio playback works fine in the application itself.

This change fixed my issue and seems to align with the intent of the nearby comment.

dpaulat commented 3 weeks ago

The fix looks good to me, but then I'm not sure why this is currently working on other operating systems. I'll have some time to look at this briefly in the next day or 2.

dpaulat commented 3 weeks ago

The failure is due to a compatibility issue between Conan v1.x and the latest version of Visual Studio (1940/17.10). There isn't much appetite for the conan developers to fix this in v1.x, but there is a fix for v2.x. Merging despite the failure, to keep from holding this open.