dpb587 / ssoca

SSO for services that use CA-based authentication.
https://dpb587.github.io/ssoca/
MIT License
10 stars 2 forks source link

Extra arguments seem to be ignored in openvpn exec #12

Closed dpb587 closed 5 years ago

dpb587 commented 5 years ago

The ssoca openvpn exec command is supposed to accept additional arguments to pass to openvpn in addition to the generated --config file.

For example, I expect the following to work, but the --tls-version-max doesn't seem to be respected.

$ ssoca openvpn exec -- --tls-version-max 1.2

Interestingly, typo'ing the argument does seem to suggest it's correctly being passed to openvpn because it errors.

$ ssoca -e pws-prod openvpn exec -- --tls-version-max=1.2
Options error: Unrecognized option or missing or extra parameter(s) in [CMD-LINE]:1: tls-version-max=1.2 (2.4.7)
Use --help for more information.

Make it work, or figure out why it's not actually supported.

Notes:

mhoran commented 5 years ago

I filed a bug with Debian for the TLSv1.3 issue.

dpb587 commented 5 years ago

This appears to be working as expected (verified with --verb 11). The underlying error suggesting this issue turned out to be caused by #13, which has nothing to do with missing, propagated options.