search

dpbriggs / growable-bloom-filters

Safe, Growable Bloom Filters in Rust (with serde)
MIT License
24 stars 8 forks source link

Why are seeds regenerated every time? #2

Closed Jimmy-Z closed 3 years ago

Jimmy-Z commented 3 years ago

https://github.com/dpbriggs/growable-bloom-filters/blob/master/src/lib.rs#L64

Why not simply store k1~k4 in self in new?

dpbriggs commented 3 years ago

Hey, thanks for catching that! Definitely an oversight. I've pushed 1.0.3 (a596552) which stores k1~k4 inline.

dpbriggs commented 3 years ago

I think I'll close this issue as fixed. If you notice anything else, please feel free to make another issue or a pull request. Or comment on this issue.

Thanks for taking an interest!