search

dpc-sdp / dev-tools

Tools used for development of Tide distribution and modules.
2 stars 1 forks source link

Fixed ahoy not failing on errors within commands. #12

Closed AlexSkrypnyk closed 5 years ago

AlexSkrypnyk commented 5 years ago

Currently, only last command ran in ahoy command will return its exit code. This is a problem, because any errors triggered within previously ran commands will not be caught resulting in false positives.

The PR addresses the problem by running all ahoy commands with set -e and commands that ahoy runs itself with set -e

Please be aware that once merge, this can uncover that some of the project are failing their builds.

anthony-malkoun commented 5 years ago

Hi @alexdesignworks what is the root issue this is trying to fix? Is this related to deploys on Openshift appearing to run successfully but in reality they're failing?

I am loathe to merge this directly into master if it is going to break builds. I would prefer to use your GH_COMMIT flag to test which builds it is going to break and fixing them first, especially given that we're trying to get all the JSONAPI version 2 stuff out at the same time.

anthony-malkoun commented 5 years ago

Two other points//questions.

  1. Should we be worried that this project itself doesn't pass build?
  2. This should be merged into the branch from my PR preferably as builds are working against that at the moment.
AlexSkrypnyk commented 5 years ago

@anthony-malkoun the root cause is that some sites a passing CI but they should not. For example, a config import may fail, but because followed by another command that passes, the whole ahoy command passes, but should fail.

This describes hot to test before merging. Please do not merge before testing :)) https://github.com/dpc-sdp/dev-tools#maintenance

Should we be worried that this project itself doesn't pass build? This is due to changes to jsonapi 2.0 and drupal 8.6 - i was under assumption that once this work is done in tide_core - this project will be passing.