dpc-sdp / dev-tools

Tools used for development of Tide distribution and modules.
2 stars 1 forks source link

Fixed project name not correctly handling underscores and hyphens. #3

Closed AlexSkrypnyk closed 5 years ago

AlexSkrypnyk commented 5 years ago

PROJECT_NAME should not be changed from how it actually been specified. It had erroneous code to strip underscores in order to make the local dev URL to not contain underscores. As a byproduct of this - the docker compose project name was affected as well, resulting in all containers having underscores stripped, which is not a standard behaviour of docker compose (it just uses the dir name): tide_api would become tideapi.

This PR addresses this problem and applies stripping of underscore only for URL. It also adds replacement of the space character with hyphen in URL.

The test build of the project that uses this change is here https://circleci.com/workflow-run/583e1ca3-315c-4ee8-a115-55f5865d98ba