dpc-sdp / dev-tools

Tools used for development of Tide distribution and modules.
2 stars 1 forks source link

Upgrades dev-tools to use Drupal 9 #58

Closed vincent-gao closed 3 years ago

vincent-gao commented 3 years ago

Issues

  1. gojq version issue
  2. rewrite the script for merging 2 composer configs .
  3. tide_core module upgrading
  4. lagoon doesn't support Drush 10

    • Drush 10 has moved to use the yaml configurations instead of drush/aliases.drushrc.php, which makes us losing ability to inject {ENV.LAGOON_ROUTE} to the drush command.
      
      In Request.php line 1174:

    Invalid Host "${env.lagoon_route}".

    
    I noticed that lagoon has a file that resides in `/home/.drush/drush.yml`
    ```bash
    # Lagoon global drush.yml file
    # This file tells Drush 9 about the lagoon environment

options: root: '/app/${env.WEBROOT}' uri: '${env.LAGOON_ROUTE}'

But local env doesn't have `LAGOON_ROUTE` variable. 
   -  current workaround , I just define required env variable  at https://github.com/dpc-sdp/dev-tools/pull/58/files#diff-4781086fb4970c687170cb2a718ef8c072ab6e6d9f9990e77e5f385e0434852aR12
   ```bash
WEBROOT=${WEBROOT:-docroot}
URI= ${LOCALDEV_URL:-dev}

  1. CONFIG_SYNC_DIRECTORY is not supported
  2. dependency issues
  3. integratedexperts/behat-relativity doesn't support Drupal 9

8 . we will use Drupal\MinkExtension behat extesion.


  1. CI failed because gojq hasn’t made it into the 3.x image on Docker Hub yet

vincent-gao commented 3 years ago

@vincent-gao I've raised a query on your comment wrt the change to the composer merge script. There's a significant reduction to the readability of the script which would impact future dev.

Thanks for the review @GROwen , just answered your question on https://github.com/dpc-sdp/dev-tools/pull/58#discussion_r727665473