[R20-402] design feedback for media embeds - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

18 stars 13 forks source link

[R20-402] design feedback for media embeds #1201

Closed lambry closed 1 month ago

lambry commented 1 month ago

Issue: https://digital-vic.atlassian.net/browse/R20-402

What I did

Design feedback for media embeds

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

netlify[bot] commented 1 month ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	4a3932d49b5171a824cd59ead015af997c941187
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/665d69935294f20008a4ff2a

cypress[bot] commented 1 month ago

Passing run #1841 ↗︎

0

160

0

0

0

Details:

feat(@dpc-sdp/ripple-ui-core): design feedback for media embeds
Project: ripple-framework	Commit: `4a3932d49b`
Status: Passed	Duration: 07:21 💡
Started: Jun 3, 2024 6:58 AM	Ended: Jun 3, 2024 7:06 AM

Review all test suite changes for PR #1201 ↗︎