[R20-1977] - Patch vite-plugin-vue to fix CSS files not triggering HMR - Githubissues

dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.

Apache License 2.0

18 stars 13 forks source link

[R20-1977] - Patch vite-plugin-vue to fix CSS files not triggering HMR #1206

Closed jeffdowdle closed 1 month ago

jeffdowdle commented 1 month ago

Issue: https://digital-vic.atlassian.net/browse/R20-1977

What I did

Used the suggested solution here to patch the Vue Vite plugin https://github.com/vitejs/vite-plugin-vue/issues/397
I tested locally and CSS now updates on save without a restart, and the rest of the project seems to work as before.

How to test

Checklist

For all PR's

[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)

For new components only

[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus

netlify[bot] commented 1 month ago

Deploy Preview for ripple-docs canceled.

Name	Link
Latest commit	b4e0f3fca79b28731f69c7bdbfad9e08ae0e12b4
Latest deploy log	https://app.netlify.com/sites/ripple-docs/deploys/665e70c57170e00008cf5495

cypress[bot] commented 1 month ago

Passing run #1850 ↗︎

0

161

0

0

0

Details:

chore: patch vite-plugin-vue to fix CSS files not triggering HMR
Project: ripple-framework	Commit: `b4e0f3fca7`
Status: Passed	Duration: 07:24 💡
Started: Jun 4, 2024 1:41 AM	Ended: Jun 4, 2024 1:49 AM

Review all test suite changes for PR #1206 ↗︎