dpc-sdp / ripple-framework

Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.
Apache License 2.0
18 stars 13 forks source link

fix(@dpc-sdp/ripple-tide-search): update search-ui packages #1207

Closed lambry closed 1 month ago

lambry commented 1 month ago

What I did

Checklist

For all PR's

For new components only

netlify[bot] commented 1 month ago

Deploy Preview for ripple-docs canceled.

Name Link
Latest commit 3c652673dee8b6817c85dbdfaf08dce0e0dc30a0
Latest deploy log https://app.netlify.com/sites/ripple-docs/deploys/665eb80291520e000877b78e
cypress[bot] commented 1 month ago

Passing run #1858 ↗︎

0 161 0 0 Flakiness 0

Details:

fix(@dpc-sdp/ripple-tide-search): update elastic search packages
Project: ripple-framework Commit: 3c652673de
Status: Passed Duration: 07:00 💡
Started: Jun 4, 2024 6:47 AM Ended: Jun 4, 2024 6:54 AM

Review all test suite changes for PR #1207 ↗︎

lambry commented 1 month ago

I'd like to actually address the issue rather than just pin the dependencies, can we have a go at removing the transpile steps here https://github.com/dpc-sdp/ripple-framework/blob/develop/packages/ripple-tide-search/nuxt.config.ts#L38 and seeing if we can get it working with the latest version?

Hey @dylankelly, the Search UI packages have been updated to their latest versions.

The site search doesn't work without the transpile step though, seems to be due to @searchkit/sdk which is a dependency @elastic/search-ui-elasticsearch-connector that hasn't been updated (in a long time).