issues
search
dpc-sdp
/
ripple-framework
Ripple is the presentation layer for building websites on the DPC Single Digital Presence platform.
Apache License 2.0
18
stars
13
forks
source link
[R20-402] add new portrait aspect ratio for media embed
#1212
Closed
lambry
closed
1 month ago
lambry
commented
1 month ago
Issue
:
https://digital-vic.atlassian.net/browse/R20-402
What I did
Add new portrait aspect ratio for media embed, the confluence doc had the wrong aspect ratio i.e. 4/3 when it should have been 3/4
Checklist
For all PR's
[ ] I've added relevant changes to the project Readme if needed.
[ ] I've updated the documentation site as needed.
[ ] I have added unit tests to cover my changes (if not applicable, please state why in a comment)
For new components only
[ ] I have added a story covering all variants
[ ] I have checked a11y tab in storybook passes
[ ] Any events are emitted on the event bus
netlify[bot]
commented
1 month ago
✅
Deploy Preview for
ripple-docs
canceled.
Name
Link
🔨
Latest commit
1bfa21d3f6bb6bce6d77288c4f1dba43c697032c
🔍
Latest deploy log
https://app.netlify.com/sites/ripple-docs/deploys/66614a8c92c12a000822bc26
Issue: https://digital-vic.atlassian.net/browse/R20-402
What I did
Checklist
For all PR's
For new components only